-
Notifications
You must be signed in to change notification settings - Fork 2.8k
auber - Technical Training #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
barracudapps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review your commit message and its title to follow Odoo's Git Guidelines
FYI
[REV] stands for Revert. Here, you didn't revert anything, you didn't "erase" something but changes/added. IMHO [FIX] would've been a better tag
69edf2e to
f578c54
Compare
barracudapps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aurb9
Can you please consider my nit and apply it wherever it suits ?
Thanks!
barracudapps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review requiring some changes (nit)
|
@aurb9 |
Solved -- was importing the views in the wrong order |
barracudapps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Please adapt your PR title and message to summarize your work.
Then, you can squash your commits and mark the PR as ready 🚀
This is for a common R&D flow having pre-review requirements, nothing to do for the training 😉 |
This provides an implementation for a module allowing people to manage their properties, people to place offers and alters the users' view to include the list of properties being sold by the person
ce00226 to
a7e4365
Compare

This provides an implementation for a module allowing people to manage their properties, people to place offers and alters the users' view to include the list of properties being sold by the person