Skip to content

Conversation

@aurb9
Copy link

@aurb9 aurb9 commented Dec 15, 2025

This provides an implementation for a module allowing people to manage their properties, people to place offers and alters the users' view to include the list of properties being sold by the person

@robodoo
Copy link

robodoo commented Dec 15, 2025

Pull request status dashboard

@barracudapps barracudapps self-requested a review December 15, 2025 14:00
Copy link

@barracudapps barracudapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review your commit message and its title to follow Odoo's Git Guidelines

FYI
[REV] stands for Revert. Here, you didn't revert anything, you didn't "erase" something but changes/added. IMHO [FIX] would've been a better tag

@aurb9 aurb9 force-pushed the 19.0-tutorials-auber branch 2 times, most recently from 69edf2e to f578c54 Compare December 16, 2025 12:43
Copy link

@barracudapps barracudapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aurb9
Can you please consider my nit and apply it wherever it suits ?
Thanks!

@aurb9 aurb9 requested a review from barracudapps December 18, 2025 10:06
Copy link

@barracudapps barracudapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review requiring some changes (nit)

@barracudapps
Copy link

@aurb9
You still have an issue on runbot with your XML file estate_property_type_views.xml. Try to make it green

@aurb9
Copy link
Author

aurb9 commented Dec 19, 2025

@aurb9 You still have an issue on runbot with your XML file estate_property_type_views.xml. Try to make it green

Solved -- was importing the views in the wrong order

@aurb9 aurb9 closed this Dec 19, 2025
@aurb9 aurb9 reopened this Dec 19, 2025
@aurb9 aurb9 requested a review from barracudapps December 19, 2025 12:23
@aurb9 aurb9 requested a review from barracudapps December 19, 2025 16:21
Copy link

@barracudapps barracudapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Please adapt your PR title and message to summarize your work.
Then, you can squash your commits and mark the PR as ready 🚀

@barracudapps
Copy link

mark the PR as ready 🚀

This is for a common R&D flow having pre-review requirements, nothing to do for the training 😉

This provides an implementation for a module allowing people to manage their properties, people to place offers and alters the users' view to include the list of properties being sold by the person
@aurb9 aurb9 force-pushed the 19.0-tutorials-auber branch from ce00226 to a7e4365 Compare December 22, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants